fixing minor static analysis complaints#1080
Merged
Merged
Conversation
fixing static analysis complaints, most of which were from psalm when run with --show-info remove deprecated httplug discovery static data providers (phpunit10 requirement)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1080 +/- ##
============================================
- Coverage 81.65% 81.41% -0.25%
+ Complexity 2195 2189 -6
============================================
Files 280 280
Lines 6254 6243 -11
============================================
- Hits 5107 5083 -24
- Misses 1147 1160 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bobstrecansky
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing static analysis complaints, most of which were from psalm when run with --show-info
static data providers (phpunit10 requirement)