Skip to content

rename log record processors#1073

Merged
brettmc merged 1 commit intoopen-telemetry:mainfrom
brettmc:rename-log-processors
Jul 10, 2023
Merged

rename log record processors#1073
brettmc merged 1 commit intoopen-telemetry:mainfrom
brettmc:rename-log-processors

Conversation

@brettmc
Copy link
Copy Markdown
Contributor

@brettmc brettmc commented Jul 5, 2023

per TC review, align log record processor names with those used in the spec

Fixes: #1063

per TC review, align log record processor names with those used in the spec
@brettmc brettmc requested a review from a team July 5, 2023 05:58
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 5, 2023

Codecov Report

Merging #1073 (4c09eb2) into main (6387992) will not change coverage.
The diff coverage is 57.14%.

❗ Current head 4c09eb2 differs from pull request most recent head f82fbaa. Consider uploading reports for the commit f82fbaa to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1073   +/-   ##
=========================================
  Coverage     81.67%   81.67%           
  Complexity     2187     2187           
=========================================
  Files           278      278           
  Lines          6231     6231           
=========================================
  Hits           5089     5089           
  Misses         1142     1142           
Flag Coverage Δ
7.4 80.32% <57.14%> (ø)
8.0 81.61% <57.14%> (ø)
8.1 81.74% <57.14%> (ø)
8.2 81.74% <57.14%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Logs/LoggerProviderBuilder.php 88.88% <0.00%> (ø)
src/SDK/Logs/Processor/BatchLogRecordProcessor.php 100.00% <ø> (ø)
src/SDK/Logs/Processor/MultiLogRecordProcessor.php 0.00% <ø> (ø)
src/SDK/Logs/Processor/NoopLogRecordProcessor.php 100.00% <ø> (ø)
...rc/SDK/Logs/Processor/SimpleLogRecordProcessor.php 100.00% <ø> (ø)
src/SDK/Logs/LogRecordProcessorFactory.php 95.83% <80.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6387992...f82fbaa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SimpleLogProcessor should be named SimpleLogRecordProcessor

2 participants