test(opentelemetry-configuration): ensure process.env is cleaned up after envVariableSubstitution() tests
#6026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter envVariableSubstitution tests
cjihrig
commented
Oct 18, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6026 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 313 313
Lines 8799 8799
Branches 1888 1888
=======================================
Hits 8360 8360
Misses 439 439 🚀 New features to boost your workflow:
|
maryliag
approved these changes
Oct 19, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The
envVariableSubstitution()test currently cleans up its modified environment variables at the end of the test body. This is unreliable because if the test fails, the clean up code is not run, and can leak environment variables into surrounding tests.Fixes # N/A
Short description of the changes
This commit moves the cleanup into
afterEach()hook. The test is also moved into its own suite to keep the cleanup properly scoped, and allow for additional tests in the future.Type of change
How Has This Been Tested?
Checklist: