Skip to content

test(exporter-jaeger): clean up OTEL_EXPORTER_JAEGER_AGENT_PORT between tests #6003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maryliag merged 1 commit into from
Oct 10, 2025
Merged

test(exporter-jaeger): clean up OTEL_EXPORTER_JAEGER_AGENT_PORT between tests #6003

maryliag merged 1 commit into from
Oct 10, 2025

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 10, 2025

Which problem is this PR solving?

process.env.OTEL_EXPORTER_JAEGER_AGENT_PORT is not cleaned up between tests like process.env.OTEL_EXPORTER_JAEGER_AGENT_HOST is.

Fixes # N/A

Short description of the changes

OTEL_EXPORTER_JAEGER_AGENT_HOST is already cleaned up between tests. This commit also cleans up OTEL_EXPORTER_JAEGER_AGENT_PORT, which is used in several tests.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Existing test suite.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@cjihrig
test(exporter-jaeger): clean up OTEL_EXPORTER_JAEGER_AGENT_PORT betwe…
90cfecb 
…en tests

OTEL_EXPORTER_JAEGER_AGENT_HOST is already cleaned up between tests.
This commit also cleans up OTEL_EXPORTER_JAEGER_AGENT_PORT, which
is used in several tests.
@cjihrig cjihrig requested a review from a team as a code owner October 10, 2025 19:00
@codecov
Copy link

codecov bot commented Oct 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.22%. Comparing base (8959e39) to head (90cfecb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6003   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files         311      311           
  Lines        8603     8603           
  Branches     1801     1801           
=======================================
  Hits         8192     8192           
  Misses        411      411
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maryliag maryliag added this pull request to the merge queue Oct 10, 2025
Merged via the queue into open-telemetry:main with commit a26422d Oct 10, 2025
25 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Oct 10, 2025

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@cjihrig cjihrig deleted the jaeger-tests branch October 11, 2025 00:04
@cjihrig cjihrig mentioned this pull request Oct 11, 2025
Merged
5 tasks
@otelbot-js otelbot-js bot mentioned this pull request Oct 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maryliag maryliag maryliag approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cjihrig @maryliag