Skip to content

test(shim-opentracing): add comparison thresholds in flaky assertions #5974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pichlermarc merged 2 commits into from
Oct 1, 2025
Merged

test(shim-opentracing): add comparison thresholds in flaky assertions #5974

pichlermarc merged 2 commits into from
Oct 1, 2025

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 30, 2025

Which problem is this PR solving?

These equality assertions can be flaky due to floating point math.

Fixes: https://github.com/open-telemetry/opentelemetry-js/actions/runs/18082260606/job/51447397928?pr=5962

Short description of the changes

This commit updates the assertions to allow a small threshold.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Existing test suite

Checklist:

  • Followed the style guidelines of this project

@cjihrig
test(shim-opentracing): add comparison thresholds in flaky assertions
26915d3 
These equality assertions can be flaky due to floating point math.
This commit updates the assertions to allow a small threshold.
@cjihrig cjihrig requested a review from a team as a code owner September 30, 2025 20:12
@codecov
Copy link

codecov bot commented Sep 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.17%. Comparing base (09bf31e) to head (4c6d26b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5974   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files         316      316           
  Lines        8521     8521           
  Branches     1763     1763           
=======================================
  Hits         8110     8110           
  Misses        411      411
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pichlermarc
pichlermarc approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🙂

@pichlermarc pichlermarc enabled auto-merge October 1, 2025 08:04
@pichlermarc pichlermarc added this pull request to the merge queue Oct 1, 2025
Merged via the queue into open-telemetry:main with commit a594098 Oct 1, 2025
25 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Oct 1, 2025

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@cjihrig cjihrig deleted the threshold branch October 1, 2025 13:42
@otelbot-js otelbot-js bot mentioned this pull request Oct 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cjihrig @pichlermarc