fix(instrumentation-fetch): include correct esm version of semconv #5878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentm
changed the title
Contributor
|
@overbalance Thanks! Can you add an entry to "experimental/CHANGELOG.md" please? |
trentm
approved these changes
Aug 26, 2025
Contributor
trentm
left a comment
trentm
left a comment
There was a problem hiding this comment.
Modulo the missing changelog entry, this LGTM.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5878 +/- ##
=======================================
Coverage 95.06% 95.06%
=======================================
Files 307 307
Lines 8031 8031
Branches 1627 1627
=======================================
Hits 7635 7635
Misses 396 396 🚀 New features to boost your workflow:
|
pichlermarc
approved these changes
Aug 27, 2025
david-luna
approved these changes
Aug 27, 2025
overbalance
force-pushed
the
freeze/use-esm-version-of-semconv
branch
from
bdb51e7 to
b06489f
Compare
overbalance
force-pushed
the
freeze/use-esm-version-of-semconv
branch
from
b06489f to
b7c0323
Compare
pichlermarc
approved these changes
Aug 27, 2025
Contributor
|
Thank you for your contribution @overbalance! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This was referenced Sep 2, 2025
6 tasks
Joozty
pushed a commit
to Joozty/opentelemetry-js
that referenced
this pull request
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When including the esm/esnext version of
@opentelemetry/instrumentation-fetch, it incorrectly imports the commonjs version of semconv.jsShort description of the changes
Type of change
How Has This Been Tested?
Compile the package and observe the correct path in the build folder:
../src/semconv->./semconvChecklist: