Skip to content

Conversation

@trentm
Copy link
Contributor

@trentm trentm commented Aug 15, 2025

Refs: #5851

@trentm trentm self-assigned this Aug 15, 2025
@trentm trentm requested a review from a team as a code owner August 15, 2025 00:12
@trentm
Copy link
Contributor Author

trentm commented Aug 15, 2025

The node-windows-tests (from unit-test.yml) failed for me on PR #5832

https://github.com/open-telemetry/opentelemetry-js/actions/runs/16979308247/job/48135685486?pr=5832

...
> @opentelemetry/[email protected] test
> nyc mocha 'test/**/*.test.ts'


 Exception during run: file:///D:/a/opentelemetry-js/opentelemetry-js/api/test/tree-shaking/tree-shaking.test.ts:20
import { IFS, Union } from 'unionfs';
         ^^^
SyntaxError: Named export 'IFS' not found. The requested module 'unionfs' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'unionfs';
const { IFS, Union } = pkg;

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:228:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:335:5)
...

This is the same type-stripping issue as #5851

@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.01%. Comparing base (927032f) to head (2a3487f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5854   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         303      303           
  Lines        7943     7943           
  Branches     1607     1607           
=======================================
  Hits         7547     7547           
  Misses        396      396           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trentm trentm added this pull request to the merge queue Aug 15, 2025
Merged via the queue into open-telemetry:main with commit b4a205e Aug 15, 2025
25 of 26 checks passed
@trentm trentm deleted the trentm-disable-strip-types-node-22-windows-too branch August 15, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants