ci: disable --experimental-strip-types on Node.js 22 #5851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5851 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 303 303
Lines 7943 7943
Branches 1607 1607
=======================================
Hits 7547 7547
Misses 396 396 🚀 New features to boost your workflow:
|
legendecas
approved these changes
Aug 12, 2025
Member
legendecas
left a comment
legendecas
left a comment
There was a problem hiding this comment.
Upgrading mocha may also address the issue: #5850. But it seems like CI is failing on the moca upgrade.
Member
Author
yep, seems to be something on the latest Node.js v20 version only. I've looked into it briefly but was not able to find out yet what's wrong 😕 |
3 tasks
trentm
added a commit
to trentm/opentelemetry-js
that referenced
this pull request
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Relates to #5415
Relates to nodejs/node#59364
Short description of the changes
disable
--experimental-strip-typeson Node.js 22