feat(web): Add session handling implementation #5173
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5173 +/- ##
==========================================
- Coverage 95.24% 95.22% -0.02%
==========================================
Files 315 311 -4
Lines 8604 8574 -30
Branches 1798 1796 -2
==========================================
- Hits 8195 8165 -30
Misses 409 409 🚀 New features to boost your workflow:
|
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
looks good overall, just a few questions/nits. 🙂
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
@martinkuba friendly ping 🙂 |
|
Hi @pichlermarc, yes, this is still something that I want to see to completion. I have put it temporarily on hold while we are trying to spin up a new SIG for browser instrumentation/API (see open-telemetry/community#2751). In any case, I am planning to come back to this in the near future. |
martinkuba
force-pushed
the
session-manager
branch
from
e4de3f2 to
2a253ec
Compare
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
Just some small comments from my side - but overall looks good to merge. 🙌
Co-authored-by: Marc Pichler <[email protected]>
martinkuba
force-pushed
the
session-manager
branch
from
cfc82cf to
1750b25
Compare
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
Looks good, one more commment around using factory functions instead.
I'll wait for the other conversations on the PR to be resolved before merging. Please feel free to ping me when you're ready.
martinkuba
force-pushed
the
session-manager
branch
from
85a0123 to
26d7983
Compare
4 participants
Which problem is this PR solving?
Follow up to #4972
Discussed in issue open-telemetry/opentelemetry-js-contrib#2358
Short description of the changes
This adds an implementation of session management for web. It introduces a
SessionManagerclass that is responsible for starting, ending, and persisting sessions.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: