feat(metrics): adds NoopMeter implementation#278
Merged
bg451 merged 10 commits intoopen-telemetry:masterfrom Sep 19, 2019
Merged
feat(metrics): adds NoopMeter implementation#278bg451 merged 10 commits intoopen-telemetry:masterfrom
bg451 merged 10 commits intoopen-telemetry:masterfrom
Conversation
bg451
requested review from
OlivierAlbertini,
danielkhan,
iredelmeier,
mayurkale22,
rochdev and
vmarchaud
as code owners
mayurkale22
reviewed
Sep 17, 2019
| return; | ||
| } | ||
|
|
||
| record(value: number, distContext: DistributedContext): void { |
Member
There was a problem hiding this comment.
Duplicate function implementation is not allowed, I think you should change this to:
record(
value: number,
distContext?: DistributedContext,
spanContext?: SpanContext
): void {
return;
}
Member
There was a problem hiding this comment.
or you can use typescript overload, something like :
https://www.typescriptlang.org/play/index.html#code/ATDGBsEMGduA5A9ogDsA3gKBCATgU1EVwBMAKAN0nAFd8AuYAOxoFsAjfXAGmBIEtoAFwDCiJkPwAPIY0hMAngEpGFRPxIBubDgJFSZHThxVaDZm048jxvoNHjJMuYu43j0FPLETpQgPwuCjYqwGoaGO66+EI0uEzaxgC+OikgQA
mayurkale22
reviewed
Sep 17, 2019
mayurkale22
reviewed
Sep 17, 2019
mayurkale22
reviewed
Sep 17, 2019
mayurkale22
reviewed
Sep 17, 2019
draffensperger
approved these changes
Sep 17, 2019
Contributor
draffensperger
left a comment
draffensperger
left a comment
There was a problem hiding this comment.
LGTM pending Mayur's request to use real objects in the unit tests instead of force casting with as
Member
|
@bg451 Feel free to merge once build passed |
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* fix(express): listener leak * chore(express): more middleware tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #264
This change is