Add instrumentation for druid connection pool#9935
Conversation
| } | ||
|
|
||
| dependencies { | ||
| library("com.alibaba:druid:0.2.6") |
There was a problem hiding this comment.
For simplicity, and since 1.0.0 was released in 2013 I'd recommend going ahead and baselining against 1.0 and renaming the module to druid-1.0
| group.set("com.alibaba") | ||
| module.set("druid") | ||
| versions.set("[0.2.6,)") | ||
| skip("1.0.30") |
There was a problem hiding this comment.
| skip("1.0.30") | |
| skip("1.0.30") | |
| assertInverse.set(true) |
There was a problem hiding this comment.
@trask assertInverse.set(true) will make muzzle3 check failed ,history check
There was a problem hiding this comment.
I think your best option is to set the version range back to versions.set("[0.2.6,)") so you could add assertInverse.set(true). The same approach is used in
There was a problem hiding this comment.
Can I write in this way
muzzle {
pass {
group.set("com.alibaba")
module.set("druid")
versions.set("[0.1.18,)")
skip("1.0.30")
assertInverse.set(true)
}
}
There was a problem hiding this comment.
@AlchemyDing sure, I think you can also use versions.set("(,)") if muzzle passes on all published versions.
|
Overall looks nice, the only open question for me is whether we should name this |
I think named alibaba-druid is better. |
resolve issue
connection pools mertric, like hikaricp, DBCP ,c3p0 , etc...