Add instrumentation for vert.x redis client#9838
Merged
Merged
Conversation
laurit
force-pushed
the
vertx-redis-client
branch
from
November 10, 2023 13:06
93464ed to
52d5ffb
Compare
breedx-splk
reviewed
Dec 5, 2023
breedx-splk
approved these changes
Dec 5, 2023
breedx-splk
left a comment
breedx-splk
left a comment
Contributor
There was a problem hiding this comment.
This looks really good to me. Nice work! I had a question about error spans, and a few small nits otherwise...seems mergeworthy to me.
laurit
force-pushed
the
vertx-redis-client
branch
from
December 6, 2023 12:31
52d5ffb to
8b38aea
Compare
trask
approved these changes
Dec 6, 2023
laurit
force-pushed
the
vertx-redis-client
branch
from
December 7, 2023 13:24
8b38aea to
d5eb190
Compare
zeitlinger
pushed a commit
to zeitlinger/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds instrumentation for vert.x redis client. Instrumentation is added only for sending commands one by one, support for batch commands is not implemented.