Skip to content

rename telemetry.auto.version to telemetry.distro.version and add telemetry.distro.name#9065

Merged
trask merged 6 commits into
open-telemetry:mainfrom
zeitlinger:auto-name
Dec 13, 2023
Merged

rename telemetry.auto.version to telemetry.distro.version and add telemetry.distro.name#9065
trask merged 6 commits into
open-telemetry:mainfrom
zeitlinger:auto-name

Conversation

@zeitlinger

@zeitlinger zeitlinger commented Jul 27, 2023

Copy link
Copy Markdown
Member

@zeitlinger
zeitlinger requested a review from a team July 27, 2023 15:29
@zeitlinger
zeitlinger marked this pull request as draft July 27, 2023 15:29

@mateuszrzeszutek mateuszrzeszutek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zeitlinger zeitlinger self-assigned this Dec 8, 2023
@zeitlinger
zeitlinger marked this pull request as ready for review December 8, 2023 16:11
Comment thread smoke-tests/src/test/groovy/io/opentelemetry/smoketest/AppServerTest.groovy Outdated
@trask

trask commented Dec 12, 2023

Copy link
Copy Markdown
Member

@zeitlinger can you update the PR title? thx

@zeitlinger zeitlinger changed the title add telemetry.auto.name rename telemetry.auto.version to telemetry.distro.version and add telemetry.distro.name Dec 13, 2023
@zeitlinger

Copy link
Copy Markdown
Member Author

@zeitlinger can you update the PR title? thx

done

@trask
trask merged commit 1a054a5 into open-telemetry:main Dec 13, 2023
@zeitlinger
zeitlinger deleted the auto-name branch December 14, 2023 11:01
elbiocaetano pushed a commit to elbiocaetano/opentelemetry-java-instrumentation that referenced this pull request Dec 19, 2023
zzhlogin added a commit to aws-observability/aws-otel-python-instrumentation that referenced this pull request Feb 27, 2024
*Issue #, if available:*

In Java,` telemetry.auto.version` resource attribute is being deprecated
([PR](open-telemetry/opentelemetry-java-instrumentation#9065)).
However, We don't find any related change in upstream. It is still
[being
used](https://github.com/open-telemetry/opentelemetry-python/blob/da48e0b131ff34ff382b7d1206f71b2e31929cab/opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py#L364),
so we are not going to deprecate it in aws-opentelemetry-distro for now.
And we use `aws-opentlemetry-distro` version with "-aws" post-fix to be
the `telemetry.auto.version `, which match with the [Java
implementation](https://github.com/aws-observability/aws-otel-java-instrumentation/blob/294e957afbf48e766e3be9a11638050ef3736904/otelagent/build.gradle.kts#L101).

Testing:
Tested resource attributed are generated:
Before the change:
```
"resource": "BoundedAttributes({'telemetry.sdk.language': 'python', 'telemetry.sdk.name': 'opentelemetry', 'telemetry.sdk.version': '1.22.0', 'service.name': 'unknown_service', 'telemetry.auto.version': '0.43b0'}, maxlen=None)"
```
After the change:
```
"resource": "BoundedAttributes({'telemetry.sdk.language': 'python', 'telemetry.sdk.name': 'opentelemetry', 'telemetry.sdk.version': '1.22.0', 'service.name': 'unknown_service', 'telemetry.auto.version':'0.0.1-aws'}, maxlen=None)"
```


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
andrzej-stencel pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jan 3, 2025
…r. (#36894)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
The PR merge in latest semconv pkg and update existing semantic
conventions utilization. And further update `awsxrayexporter` to be able
to handle following both new versions of http
span attributes:
`http.response.status_code` migrated from
[http.status_code](https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/#http-status-code)
`url.query` migrated from
[http.target](https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/#http-target).

Otel Java SDK has renamed `telemetry.auto.version` to
`telemetry.distro.version` ([Upstream
PR](open-telemetry/opentelemetry-java-instrumentation#9065)),
update `awsxrayexporter` to be able to detect both attributes.

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
N/A

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit test passed

<!--Describe the documentation added.-->
#### Documentation
N/A
AkhigbeEromo pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Jan 13, 2025
…r. (open-telemetry#36894)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
The PR merge in latest semconv pkg and update existing semantic
conventions utilization. And further update `awsxrayexporter` to be able
to handle following both new versions of http
span attributes:
`http.response.status_code` migrated from
[http.status_code](https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/#http-status-code)
`url.query` migrated from
[http.target](https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/#http-target).

Otel Java SDK has renamed `telemetry.auto.version` to
`telemetry.distro.version` ([Upstream
PR](open-telemetry/opentelemetry-java-instrumentation#9065)),
update `awsxrayexporter` to be able to detect both attributes.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
N/A

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit test passed

<!--Describe the documentation added.-->
#### Documentation
N/A
zeck-ops pushed a commit to zeck-ops/opentelemetry-collector-contrib that referenced this pull request Apr 23, 2025
…r. (open-telemetry#36894)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
The PR merge in latest semconv pkg and update existing semantic
conventions utilization. And further update `awsxrayexporter` to be able
to handle following both new versions of http
span attributes:
`http.response.status_code` migrated from
[http.status_code](https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/#http-status-code)
`url.query` migrated from
[http.target](https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/#http-target).

Otel Java SDK has renamed `telemetry.auto.version` to
`telemetry.distro.version` ([Upstream
PR](open-telemetry/opentelemetry-java-instrumentation#9065)),
update `awsxrayexporter` to be able to detect both attributes.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
N/A

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit test passed

<!--Describe the documentation added.-->
#### Documentation
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants