feat(aws-sdk): add RDS Data SQL telemetry#19259
Open
rsclarke wants to merge 2 commits into
Open
Conversation
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds RDS Data API SQL telemetry to existing AWS SDK v2 spans without runtime coupling or duplicate spans.
Changes:
- Enriches statement operations with sanitized SQL database attributes, naming, metrics, and errors.
- Preserves generic routing for transaction operations.
- Adds legacy/stable coverage across library, autoconfigure, and javaagent.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
testing/.../AbstractAws2RdsDataTest.java |
Adds shared RDS Data telemetry tests. |
testing/build.gradle.kts |
Adds the RDS Data test dependency. |
library/.../Aws2RdsDataTest.java |
Configures library tests. |
library/.../TracingExecutionInterceptor.java |
Routes RDS Data requests to the SQL instrumenter. |
library/.../RdsDataSqlAttributesGetter.java |
Extracts SQL request metadata. |
library/.../AwsSdkRequestType.java |
Defines the RDS Data request type. |
library/.../AwsSdkRequest.java |
Classifies supported statement requests. |
library/.../AwsSdkInstrumenterFactory.java |
Builds the database-enriched instrumenter. |
library/.../AwsSdkTelemetry.java |
Wires the new instrumenter into telemetry. |
library/build.gradle.kts |
Adds legacy and stable test suites. |
library-autoconfigure/.../Aws2RdsDataTest.java |
Configures autoconfigure tests. |
library-autoconfigure/build.gradle.kts |
Registers autoconfigure test suites. |
javaagent/.../Aws2RdsDataTest.java |
Configures javaagent tests. |
javaagent/build.gradle.kts |
Registers javaagent test suites. |
.github/config/latest-dep-versions.json |
Pins the latest RDS Data dependency. |
Pull request dashboard statusStatus last refreshed: 2026-07-26 23:35:19 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
Enrich ExecuteStatement and BatchExecuteStatement spans with SQL database semantic conventions while preserving legacy AWS operation names. Add isolated local-mock coverage for library, javaagent, and autoconfigure modes. Refs open-telemetry#19256
rsclarke
force-pushed
the
feat/aws-sdk-rds-data-sql
branch
from
July 19, 2026 11:59
72c6be5 to
2455b45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SQL database semantic-convention enrichment to the existing AWS SDK v2 spans for RDS Data API
ExecuteStatementandBatchExecuteStatementcalls. This provides JDBC-aligned query sanitization, summaries, database attributes, and duration metrics without adding a generated RDS Data runtime dependency or creating a duplicate nested span.other_sql, database namespace, SQL text, parameterization, and parameter-set batch size through AWS SDK core APIs.RdsData.<operation>span name in legacy-only mode and use database query-summary names in stable database-semconv mode.ExecuteSqland transaction-control operations on the existing generic AWS RPC path.Closes #19256