Skip to content

Fail SDK update when release lookup fails#19255

Open
trask wants to merge 1 commit into
open-telemetry:mainfrom
trask:fix/auto-update-sdk-pipefail
Open

Fail SDK update when release lookup fails#19255
trask wants to merge 1 commit into
open-telemetry:mainfrom
trask:fix/auto-update-sdk-pipefail

Conversation

@trask

@trask trask commented Jul 17, 2026

Copy link
Copy Markdown
Member

A transient GitHub API 503 caused gh release view to fail, but the following sed command returned success and masked the failure. The workflow then treated the latest SDK version as empty and opened #19252.

Enable pipefail in the version-check step so a failure from either command in the pipeline fails the job. The dependent update job will then not run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures SDK update automation stops when GitHub release lookup fails.

Changes:

  • Enables pipefail in the version-check step.
  • Prevents empty-version update PRs caused by masked pipeline failures.

@trask
trask marked this pull request as ready for review July 17, 2026 02:19
@trask
trask requested a review from a team as a code owner July 17, 2026 02:19
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 18, 2026

Copy link
Copy Markdown

Pull request dashboard status

Status last refreshed: 2026-07-26 20:39:33 UTC.

  • Waiting on: Reviewers
  • Next step: Review the latest changes.

This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants