Mark nonstable JMX targets experimental#18971
Merged
Merged
Conversation
trask
force-pushed
the
jmx
branch
4 times, most recently
from
June 12, 2026 05:08
42cf152 to
dddd349
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates JMX Metrics “target system” naming to clearly distinguish non-stable Kafka targets by introducing experimental-kafka-broker and experimental-kafka-connect, while preserving legacy names with warnings (outside v3 preview) and enforcing the experimental names in v3 preview.
Changes:
- Renames the Kafka broker and Kafka Connect JMX rule resources to
experimental-*filenames and updates documentation/tests accordingly. - Adds legacy-name compatibility in the javaagent installer (with warnings) when v3 preview is disabled.
- Updates Kafka Connect rule loading in library tests to use the new experimental rule resource.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| instrumentation/jmx-metrics/README.md | Updates user-facing configuration example and supported target list to the new experimental-* target names. |
| instrumentation/jmx-metrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/rules/KafkaConnectTest.java | Updates Kafka Connect integration test to load the renamed experimental rules resource. |
| instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/experimental-kafka-connect.yaml | Adds the renamed Kafka Connect JMX rules file under the experimental target name. |
| instrumentation/jmx-metrics/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jmx/JmxMetricInsightInstallerTest.java | Updates javaagent-side rule validation test to reference the renamed experimental Kafka broker rules file. |
| instrumentation/jmx-metrics/javaagent/src/main/resources/jmx/rules/experimental-kafka-broker.yaml | Adds the renamed Kafka broker JMX rules file under the experimental target name. |
| instrumentation/jmx-metrics/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jmx/JmxMetricInsightInstaller.java | Adds mapping/warnings to support legacy Kafka target names outside v3 preview and routes target names to the correct classpath rule resources. |
laurit
approved these changes
Jun 12, 2026
Member
Author
SylvainJuge
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #16016