Prepare for SQLQueryAnalyzer analyze change in 3.0#18921
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts SqlQueryAnalyzer behavior to align with upcoming semantic-conventions v3 expectations by making analyze() return summary-capable results when v3 preview mode is enabled, while keeping the existing behavior for non-preview configurations.
Changes:
- Route
SqlQueryAnalyzer.analyze()toanalyzeWithSummary()whenSemconvStability.v3Preview()is enabled. - Mark
analyzeWithSummary()as a transitional API slated for removal/inlining (recommended to formalize via deprecation).
SqlQueryAnalyzer started checking the v3 preview semconv flag, but the internal SemconvStability helper was not imported, causing :instrumentation-api-incubator:compileJava to fail across CI jobs. Import SemconvStability so the query analyzer compiles. Validation: .\gradlew.bat :instrumentation-api-incubator:compileJava
laurit
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.