Avoid NumberFormatException when port is null#18708
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts JDBC URL port parsing to avoid triggering (and logging) a NumberFormatException when the extracted port string is null, which was observed during vertx-rx-java-3.5 test runs.
Changes:
- Make
UrlParsingUtils.parsePortaccept nullable input and returnnullearly when the input isnull. - Annotate
parsePort’s parameter and return value with@Nullableto reflect the behavior.
Comment on lines
95
to
+99
| * @param value the string value to parse | ||
| * @return the parsed integer, or null if parsing fails | ||
| */ | ||
| public static Integer parsePort(String value) { | ||
| @Nullable | ||
| public static Integer parsePort(@Nullable String value) { |
Comment on lines
+98
to
+102
| @Nullable | ||
| public static Integer parsePort(@Nullable String value) { | ||
| if (value == null) { | ||
| return null; | ||
| } |
trask
approved these changes
May 12, 2026
trask
enabled auto-merge (squash)
May 12, 2026 14:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exceptions is caught. Noticed it being logged while running
vertx-rx-java-3.5tests.