Skip to content

Fix ktor empty interceptor workaround#18456

Merged
trask merged 3 commits into
open-telemetry:mainfrom
laurit:ktor-empty-interceptor
May 4, 2026
Merged

Fix ktor empty interceptor workaround#18456
trask merged 3 commits into
open-telemetry:mainfrom
laurit:ktor-empty-interceptor

Conversation

@laurit

@laurit laurit commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Resolves #18373
Apparently current version of the empty interceptor causes the updateThreadContext/restoreThreadContext to be skipped sometimes. With the updated interceptor the test that was added along with the interceptor still passes.

@laurit
laurit marked this pull request as ready for review May 1, 2026 16:56
@laurit
laurit requested a review from a team as a code owner May 1, 2026 16:56

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review.py produced the suggestion below.


Found one coroutine interceptor lifecycle issue in the Ktor workaround.

laurit and others added 2 commits May 4, 2026 10:42
@trask
trask merged commit e5bbb7e into open-telemetry:main May 4, 2026
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ktor request trace context lost after coroutine hop with 2.27.0

2 participants