Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:

• ktor-1.0:library
• ktor-2.0:javaagent
• ktor-2.0:library
• ktor-2.0:testing
• ktor-3.0:javaagent
• ktor-3.0:library
• ktor-3.0:testing
• ktor-common-2.0:library
• kubernetes-client-7.0:javaagent
• kubernetes-client-7.0:javaagent-unit-tests
• lettuce-4.0:javaagent

Module: ktor-1.0:library

Module path: instrumentation/ktor/ktor-1.0/library

Summary

Applied 1 safe review fix in instrumentation/ktor/ktor-1.0/library to align Gradle test-task wiring with repository conventions: collectMetadata now uses withType<Test>().configureEach, so both the default test run and -PtestLatestDeps=true validation receive the same metadata system property.

Applied Changes

Build

File: build.gradle.kts:32
Change: Replaced `tasks.test { ... }` with `tasks { withType<Test>().configureEach { ... } }` for the `collectMetadata` system property.
Reason: Repository Gradle review rules allow fixing missing test-task wiring patterns; configuring all `Test` tasks ensures `latestDepTest` and any other test variants inherit `collectMetadata` instead of only the default `test` task.

Module: ktor-2.0:javaagent

Module path: instrumentation/ktor/ktor-2.0/javaagent

Summary

No safe repository-guideline fixes were needed under instrumentation/ktor/ktor-2.0/javaagent; the in-scope source, tests, build script, and module metadata.yaml matched existing repository patterns.

Applied Changes

No safe automated changes were applied.

Module: ktor-2.0:library

Module path: instrumentation/ktor/ktor-2.0/library

Summary

Reviewed all files under instrumentation/ktor/ktor-2.0/library, including instrumentation/ktor/ktor-2.0/metadata.yaml against the shared Ktor/common HTTP config usage, and found no safe deterministic repository-guideline fixes to apply.

Applied Changes

No safe automated changes were applied.

Module: ktor-2.0:testing

Module path: instrumentation/ktor/ktor-2.0/testing

Summary

Reviewed all files under instrumentation/ktor/ktor-2.0/testing and the required instrumentation/ktor/ktor-2.0/metadata.yaml validation path; no safe repository-guideline fixes were needed.

Applied Changes

No safe automated changes were applied.

Module: ktor-3.0:javaagent

Module path: instrumentation/ktor/ktor-3.0/javaagent

Summary

Applied 1 safe javaagent review fix in instrumentation/ktor/ktor-3.0/javaagent; no other deterministic file-scope fixes were needed.

Applied Changes

Javaagent

File: HttpClientInstrumentation.java:46
Change: Added `suppress = Throwable.class` to `ConstructorAdvice.onEnter()`.
Reason: Repository `javaagent-advice-patterns.md` requires non-trivial `@Advice.OnMethodEnter` methods to use `suppress = Throwable.class` so instrumentation failures do not propagate into application code.

Module: ktor-3.0:library

Module path: instrumentation/ktor/ktor-3.0/library

Summary

Removed a redundant testLatestDeps JVM system property from instrumentation/ktor/ktor-3.0/library/build.gradle.kts; the module already uses the Gradle -PtestLatestDeps=true flow for latest-deps validation, and no Ktor 3.0 library tests consume an extra testLatestDeps system property.

Applied Changes

Build

File: build.gradle.kts:36
Change: Removed `systemProperty("testLatestDeps", otelProps.testLatestDeps)` from `withType<Test>().configureEach`.
Reason: Per the Gradle conventions, `-PtestLatestDeps=true` is a Gradle project property handled by the shared instrumentation build logic for latest-deps test runs; this module had no `testLatestDeps()`-based assertions, so the extra JVM system property was redundant configuration noise.

Module: ktor-3.0:testing

Module path: instrumentation/ktor/ktor-3.0/testing

Summary

Applied one safe review fix in instrumentation/ktor/ktor-3.0/testing: reduced a module-local helper to internal visibility after reviewing the scoped files and validating the required Gradle :check runs plus final spotlessApply.

Applied Changes

Style

File: KtorHttpClientSingleConnection.kt:13
Change: Changed `KtorHttpClientSingleConnection` from `public` to `internal`.
Reason: The style guide requires minimal necessary visibility, and this helper is only referenced from within the same `ktor-3.0/testing` module.

Module: ktor-common-2.0:library

Module path: instrumentation/ktor/ktor-common-2.0/library

Summary

Applied 3 safe review fixes under instrumentation/ktor/ktor-common-2.0/library: removed an unused import, converted Experimental to an idiomatic Kotlin object, and tightened KtorServerTracer visibility to internal with the required Ktor module validation completed.

Applied Changes

Style

File: AbstractKtorClientTelemetryBuilder.kt:18
Change: Removed the unused `java.util.function.Function` import.
Reason: The review workflow allows safe import cleanup as direct style-guide conformance, and keeping only used imports avoids dead code noise.

File: Experimental.kt:11
Change: Replaced the manual private-constructor singleton helper with a Kotlin `object` declaration.
Reason: The repository singleton guidance treats Kotlin `object` declarations as the idiomatic singleton form, so this is a safe cleanup for an internal helper without changing call sites.

File: KtorServerTracer.kt:14
Change: Reduced `KtorServerTracer` visibility from public to `internal`.
Reason: The style guide says classes in `.internal` packages are not public API and should use the most restrictive visibility that still works.

Module: kubernetes-client-7.0:javaagent

Module path: instrumentation/kubernetes-client-7.0/javaagent

Summary

Applied 2 safe review fixes under instrumentation/kubernetes-client-7.0/javaagent: tightened visibility for file-local regex constants and normalized an unused catch variable name to match repository style guidance.

Applied Changes

Style

File: KubernetesRequestDigest.java:14
Change: Made `RESOURCE_URL_PATH_PATTERN` `private` and renamed the unused catch variable to `ignored`.
Reason: The style guide requires minimal necessary visibility, and `knowledge/general-rules.md` says intentionally unused catch parameters should be named `ignored`.

File: KubernetesResource.java:14
Change: Made `CORE_RESOURCE_URL_PATH_PATTERN` and `REGULAR_RESOURCE_URL_PATH_PATTERN` `private`.
Reason: The style guide requires minimal necessary visibility; these regex constants are only used inside `KubernetesResource` itself.

Module: kubernetes-client-7.0:javaagent-unit-tests

Module path: instrumentation/kubernetes-client-7.0/javaagent-unit-tests

Summary

Reviewed instrumentation/kubernetes-client-7.0/javaagent-unit-tests, validated the parent metadata.yaml against the module code, and found no safe repository-guideline fixes to apply. Scoped validation completed successfully with ./gradlew :instrumentation:kubernetes-client-7.0:javaagent-unit-tests:check and ./gradlew :instrumentation:kubernetes-client-7.0:javaagent-unit-tests:check -PtestLatestDeps=true.

Applied Changes

No safe automated changes were applied.

Module: lettuce-4.0:javaagent

Module path: instrumentation/lettuce/lettuce-4.0/javaagent

Summary

Applied 2 safe nullability fixes in instrumentation/lettuce/lettuce-4.0/javaagent after reviewing the full module and confirming metadata.yaml config usage matched the code.

Applied Changes

Nullability

File: LettuceAsyncCommandsInstrumentation.java:52
Change: Annotated `AdviceScope.end(...)` to accept a nullable `AsyncCommand` from `@Advice.Return` on exceptional exits.
Reason: The review guideline for nullability correctness requires `@Nullable` on parameters when callers can concretely pass `null`; `onExit(...)` passes the `@Advice.Return` value, which is nullable when `dispatch` throws.

File: InstrumentationPoints.java:34
Change: Annotated `InstrumentationPoints.afterCommand(...)` to accept a nullable `AsyncCommand` along the same exceptional advice path.
Reason: The nullability rule requires propagating the concrete nullable flow instead of declaring a non-null parameter; `LettuceAsyncCommandsInstrumentation.AdviceScope.end(...)` can forward a `null` async command when the instrumented call exits with a throwable.

Download code review diagnostics