Fix #8462 - Use more permissive regexp to extract containerid#18272
Merged
Conversation
|
|
stefanroeck
force-pushed
the
fix_container_id_cgroupv2
branch
2 times, most recently
from
April 24, 2026 23:28
7f20b55 to
a98f7a1
Compare
Member
|
thanks @stefanroeck! I'm going to convert your PR to draft until you're able to resolve the CLA, and then please mark it ready for review |
trask
marked this pull request as draft
April 25, 2026 20:34
stefanroeck
force-pushed
the
fix_container_id_cgroupv2
branch
from
April 28, 2026 06:28
a98f7a1 to
4b8921d
Compare
Contributor
Author
|
/easycla |
stefanroeck
marked this pull request as ready for review
April 28, 2026 17:33
laurit
reviewed
Apr 29, 2026
stefanroeck
force-pushed
the
fix_container_id_cgroupv2
branch
from
April 29, 2026 17:23
4b8921d to
3766ef7
Compare
trask
reviewed
Apr 29, 2026
…inerid for podman /mountinfo. Also report a warning, in case of a unique containerId cannot be extracted and return the last one.
stefanroeck
force-pushed
the
fix_container_id_cgroupv2
branch
from
April 30, 2026 14:58
3766ef7 to
c7274f7
Compare
trask
approved these changes
Apr 30, 2026
trask
left a comment
trask
left a comment
Member
There was a problem hiding this comment.
@breedx-splk if you have time can you have a look as well? thanks
laurit
approved these changes
Apr 30, 2026
Contributor
|
Thank you for your contribution @stefanroeck! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #8462 by using a more strict regexp that doesn't match "/container" ocurrances in the option field area of the mountinfo file.
Also report a warning, in case a unique containerId cannot be extracted and return the last one.