Reactor 3.1: reset schedulers hook in resetOnEachOperator()#18258
Merged
Conversation
trask
force-pushed
the
reactor-schedulers-reset-hook
branch
2 times, most recently
from
April 26, 2026 00:17
5affe20 to
1f504b3
Compare
Automated code review of instrumentation/reactor/reactor-3.1/library.
trask
force-pushed
the
reactor-schedulers-reset-hook
branch
from
April 26, 2026 00:18
1f504b3 to
1669bc4
Compare
trask
marked this pull request as ready for review
April 26, 2026 00:18
…eflection for resetOnScheduleHook
trask
force-pushed
the
reactor-schedulers-reset-hook
branch
from
April 26, 2026 02:51
e11f16f to
4f0779d
Compare
laurit
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted out of #18254.
ContextPropagationOperator.registerOnEachOperator()installs two things on Reactor:onEachOperatorhook (forMono/Fluxcontext propagation), andSchedulers.onScheduleHook(...)that wraps every scheduledRunnablewithRunnableWrapperso the OpenTelemetry context is captured at schedule time and restored at execution time.The matching
resetOnEachOperator()method was only undoing (1) — it calledHooks.resetOnEachOperator(...)but never calledSchedulers.resetOnScheduleHook(...). So after a caller "disabled" the operator, scheduled tasks were still being wrapped withRunnableWrapper, leaking instrumentation behavior into code that had explicitly opted out (and preventing a clean re-register/teardown cycle).