Remove deprecated capture-event-name configuration#18223
Merged
Conversation
otelbot-java-instrumentation
Bot
added
the
test native
trask
force-pushed
the
rm-capture-event-name
branch
from
April 23, 2026 04:06
80e7093 to
79c7eb2
Compare
trask
marked this pull request as ready for review
April 23, 2026 13:33
trask
marked this pull request as draft
April 23, 2026 13:34
trask
marked this pull request as ready for review
April 23, 2026 14:22
laurit
approved these changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the deprecated captureEventName / capture-event-name configuration across Logback, Log4j, and JBoss LogManager appenders, standardizing on otel.event.name as the supported mechanism for setting log event names.
Changes:
- Deletes deprecated builder/config options and associated warnings/docs/metadata entries.
- Updates mappers and tests to exclusively use
otel.event.name(and no longer supportevent.namepromotion). - Updates changelog and internal guidance docs to reflect the deprecation/removal pattern.
Reviewed changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| instrumentation/logback/logback-appender-1.0/testing/src/main/java/io/opentelemetry/instrumentation/logback/appender/v1_0/AbstractLogbackTest.java | Simplifies event name MDC test to only cover otel.event.name. |
| instrumentation/logback/logback-appender-1.0/metadata.yaml | Removes deprecated capture-event-name config metadata. |
| instrumentation/logback/logback-appender-1.0/library/src/test/resources/logback-test.xml | Drops deprecated <captureEventName> from test config. |
| instrumentation/logback/logback-appender-1.0/library/src/test/java/io/opentelemetry/instrumentation/logback/appender/v1_0/internal/LoggingEventMapperTest.java | Removes parameterized legacy coverage; updates tests and captureAttribute calls. |
| instrumentation/logback/logback-appender-1.0/library/src/slf4j2ApiTest/resources/logback-test.xml | Drops deprecated <captureEventName> from SLF4J2 API test config. |
| instrumentation/logback/logback-appender-1.0/library/src/slf4j2ApiTest/java/io/opentelemetry/instrumentation/logback/appender/v1_0/Slf4j2Test.java | Updates key-value pair key from event.name to otel.event.name. |
| instrumentation/logback/logback-appender-1.0/library/src/main/java/io/opentelemetry/instrumentation/logback/appender/v1_0/internal/LoggingEventMapper.java | Removes deprecated event.name promotion and builder flag; simplifies attribute capture. |
| instrumentation/logback/logback-appender-1.0/library/src/main/java/io/opentelemetry/instrumentation/logback/appender/v1_0/OpenTelemetryAppender.java | Removes deprecated appender setter/flag and deprecation warning. |
| instrumentation/logback/logback-appender-1.0/library/src/logstashStructuredArgsTest/resources/logback-test.xml | Drops deprecated <captureEventName> from structured-args test config. |
| instrumentation/logback/logback-appender-1.0/library/src/logstashStructuredArgsTest/java/io/opentelemetry/instrumentation/logback/appender/v1_0/LogstashStructuredArgsTest.java | Removes legacy event.name structured-arg test. |
| instrumentation/logback/logback-appender-1.0/library/src/logstashMarkerTest/resources/logback-test.xml | Drops deprecated <captureEventName> from marker test config. |
| instrumentation/logback/logback-appender-1.0/library/src/logstashMarkerTest/java/io/opentelemetry/instrumentation/logback/appender/v1_0/LogstashMarkerTest.java | Updates marker key to otel.event.name and removes a single-field marker test. |
| instrumentation/logback/logback-appender-1.0/library/README.md | Removes captureEventName from documented settings. |
| instrumentation/logback/logback-appender-1.0/javaagent/src/test/java/io/opentelemetry/instrumentation/logback/appender/v1_0/LogbackTest.java | Deletes override used to account for deprecated behavior. |
| instrumentation/logback/logback-appender-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/logback/appender/v1_0/LogbackSingletons.java | Removes deprecated property handling and warning log. |
| instrumentation/logback/logback-appender-1.0/javaagent/README.md | Removes deprecated javaagent property from docs. |
| instrumentation/log4j/log4j-appender-2.17/testing/src/main/java/io/opentelemetry/instrumentation/log4j/appender/v2_17/AbstractLog4j2Test.java | Simplifies context data test to only cover otel.event.name. |
| instrumentation/log4j/log4j-appender-2.17/metadata.yaml | Removes deprecated capture-event-name config metadata. |
| instrumentation/log4j/log4j-appender-2.17/library/src/test/resources/log4j2.xml | Drops deprecated captureEventName plugin attribute in tests. |
| instrumentation/log4j/log4j-appender-2.17/library/src/test/java/io/opentelemetry/instrumentation/log4j/appender/v2_17/internal/LogEventMapperTest.java | Removes parameterized legacy coverage and updates mapper construction/tests. |
| instrumentation/log4j/log4j-appender-2.17/library/src/main/java/io/opentelemetry/instrumentation/log4j/appender/v2_17/internal/LogEventMapper.java | Removes deprecated event.name promotion flag and logic; standardizes on otel.event.name. |
| instrumentation/log4j/log4j-appender-2.17/library/src/main/java/io/opentelemetry/instrumentation/log4j/appender/v2_17/OpenTelemetryAppender.java | Removes deprecated builder attribute/setter/warning and wiring. |
| instrumentation/log4j/log4j-appender-2.17/library/README.md | Removes captureEventName from documented settings. |
| instrumentation/log4j/log4j-appender-2.17/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/log4j/appender/v2_17/Log4jHelper.java | Removes deprecated property handling and warning log. |
| instrumentation/log4j/log4j-appender-2.17/javaagent/build.gradle.kts | Removes deprecated test JVM arg for capture-event-name. |
| instrumentation/log4j/log4j-appender-2.17/javaagent/README.md | Removes deprecated javaagent property from docs. |
| instrumentation/log4j/log4j-appender-1.2/metadata.yaml | Removes deprecated capture-event-name config metadata. |
| instrumentation/log4j/log4j-appender-1.2/javaagent/src/test/java/io/opentelemetry/instrumentation/log4j/appender/v1_2/Log4j1Test.java | Simplifies MDC test to only cover otel.event.name. |
| instrumentation/log4j/log4j-appender-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/log4j/appender/v1_2/LogEventMapper.java | Removes deprecated property handling, warning, and legacy event.name promotion. |
| instrumentation/log4j/log4j-appender-1.2/javaagent/build.gradle.kts | Removes deprecated test JVM arg for capture-event-name. |
| instrumentation/log4j/log4j-appender-1.2/javaagent/README.md | Removes deprecated javaagent property from docs. |
| instrumentation/jboss-logmanager/jboss-logmanager-appender-1.1/metadata.yaml | Removes deprecated capture-event-name config metadata. |
| instrumentation/jboss-logmanager/jboss-logmanager-appender-1.1/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jbosslogmanager/appender/v1_1/JbossLogmanagerTest.java | Simplifies MDC test to only cover otel.event.name. |
| instrumentation/jboss-logmanager/jboss-logmanager-appender-1.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jbosslogmanager/appender/v1_1/LoggingEventMapper.java | Removes deprecated property handling, warning, and legacy event.name promotion. |
| instrumentation/jboss-logmanager/jboss-logmanager-appender-1.1/javaagent/build.gradle.kts | Removes deprecated test JVM arg for capture-event-name. |
| instrumentation/jboss-logmanager/README.md | Removes deprecated javaagent property from docs. |
| CHANGELOG.md | Documents removal of deprecated settings and points users to otel.event.name. |
| .github/agents/knowledge/config-property-stability.md | Updates internal example to use generic “old_setting” placeholder. |
Comments suppressed due to low confidence (1)
instrumentation/logback/logback-appender-1.0/library/src/main/java/io/opentelemetry/instrumentation/logback/appender/v1_0/internal/LoggingEventMapper.java:1
- The comment states
otel.event.nameis not supported in logger context properties, but the implementation will currently capture it as a normal attribute if present inloggerContextProperties. To keep behavior consistent with other capture paths (whereotel.event.nameis treated specially and not emitted as an attribute), explicitly skipotel.event.namein this loop (or adjust the comment if capturing it as an attribute is intended).
trask
enabled auto-merge (squash)
April 23, 2026 15:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.