Otel api bridging for 1.61#17849
Merged
trask merged 4 commits intoopen-telemetry:mainfrom Apr 17, 2026
Merged
Conversation
otelbot-java-instrumentation
Bot
added
the
test native
laurit
commented
Apr 15, 2026
| .getConfigProvider() | ||
| .getInstrumentationConfig("foo") | ||
| .getString("bar")) | ||
| DeclarativeConfigProperties instrumentationConfig = |
Contributor
Author
There was a problem hiding this comment.
This is how this test originally was. When the api was updated this test was changed, we should have ensured that this test used the old api instead.
laurit
commented
Apr 15, 2026
| import io.opentelemetry.api.metrics.DoubleCounter; | ||
| import io.opentelemetry.javaagent.instrumentation.opentelemetryapi.v1_10.metrics.ApplicationDoubleCounter; | ||
|
|
||
| final class ApplicationDoubleCounter140Incubator extends ApplicationDoubleCounter |
Contributor
Author
There was a problem hiding this comment.
although the new isEnabled method is implemented in the base class we still need this class for producing a counter that can be cast to ExtendedDoubleCounter
laurit
commented
Apr 15, 2026
trask
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.