Skip to content

Avoid warning on jdk26#17824

Merged
laurit merged 3 commits intoopen-telemetry:mainfrom
laurit:jdk26-warning
Apr 14, 2026
Merged

Avoid warning on jdk26#17824
laurit merged 3 commits intoopen-telemetry:mainfrom
laurit:jdk26-warning

Conversation

@laurit
Copy link
Copy Markdown
Contributor

@laurit laurit commented Apr 13, 2026

Resolves #17776

@laurit laurit requested a review from a team as a code owner April 13, 2026 06:22
@trask
Copy link
Copy Markdown
Member

trask commented Apr 13, 2026

@copilot resolve the merge conflicts in this pull request

@trask
Copy link
Copy Markdown
Member

trask commented Apr 13, 2026

https://github.blog/changelog/2026-04-13-fix-merge-conflicts-in-three-clicks-with-copilot-cloud-agent/

well, not sure why the button was there, didn't really expect it to work since the PR is from a fork, but 🤷‍♂️

}
}

private static class AgentBuilderDefaultClassFileTransformer implements ClassFileTransformer {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth tracking hookInserted as optimization like the transformers above?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo not really. We expect it to always transform the class.

@laurit laurit merged commit f7c5684 into open-telemetry:main Apr 14, 2026
93 checks passed
@laurit laurit deleted the jdk26-warning branch April 14, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Java 26 warning from reflective mutation of Byte Buddy AgentBuilder.Default.transformations under JEP 500

3 participants