Add api for exposing helper classes to app class loader#17765
Merged
trask merged 4 commits intoopen-telemetry:mainfrom Apr 17, 2026
Merged
Add api for exposing helper classes to app class loader#17765trask merged 4 commits intoopen-telemetry:mainfrom
trask merged 4 commits intoopen-telemetry:mainfrom
Conversation
jaydeluca
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let application class loader load specified classes from instrumentation class loader. Currently we create a proxy class that delegates to the helper class in instrumentation class loader. While the proxy classes work I feel it is more complicated than necessary. There are also some obscure limitations like how do you proxy a class that has a super class or implements interfaces that are also helper classes (not visible from application class loader) or what if the proxied type implements methods that either return or accept helper classes. That being said there is one area where proxies work but the proposed solution does not, that is instrumentations that run in boot loader. There is currently 1 instrumentation remaining that uses a proxy and that instrumentation runs in boot loader.