Rename statement_sanitizer to query_sanitization#17116
Merged
trask merged 2 commits intoopen-telemetry:mainfrom Apr 2, 2026
Merged
Rename statement_sanitizer to query_sanitization#17116trask merged 2 commits intoopen-telemetry:mainfrom
trask merged 2 commits intoopen-telemetry:mainfrom
Conversation
github-actions
Bot
added
the
test native
trask
force-pushed
the
rename-query-sanitizer
branch
from
78cf133 to
c4a09b2
Compare
laurit
reviewed
Mar 27, 2026
| Boolean deprecatedValue = config.get("statement_sanitizer").getBoolean("enabled"); | ||
| if (deprecatedValue != null) { | ||
| logger.warning( | ||
| "statement_sanitizer is deprecated in declarative configuration" |
Contributor
There was a problem hiding this comment.
how do you know that user is using declarative configuration not the system properties?
trask
force-pushed
the
rename-query-sanitizer
branch
from
c4a09b2 to
24d1469
Compare
trask
force-pushed
the
rename-query-sanitizer
branch
6 times, most recently
from
d9249d3 to
a475555
Compare
trask
force-pushed
the
rename-query-sanitizer
branch
from
a475555 to
30f8054
Compare
laurit
reviewed
Apr 2, 2026
| SPECIAL_MAPPINGS.put( | ||
| "java.common.database.statement_sanitizer.enabled", | ||
| "java.common.db.query_sanitization.enabled", | ||
| "otel.instrumentation.common.db-statement-sanitizer.enabled"); |
Contributor
There was a problem hiding this comment.
should the system properties also be renamed?
laurit
approved these changes
Apr 2, 2026
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the preferred declarative database configuration terminology:
statement_sanitizeris renamed toquery_sanitizationcommon.databaseis renamed tocommon.db(following https://github.com/open-telemetry/opentelemetry-configuration/blob/2cecf35f5b3aad20857ab476eaef4f01740b260a/CHANGELOG.md?plain=1#L123)The old declarative names are still accepted for compatibility, but they are now deprecated.
Following the stable database terminology change from statement to query.
And aligning with telemetry builder configuration option names.