Skip to content

Rename sql commenter builder option#17094

Merged
laurit merged 2 commits intoopen-telemetry:mainfrom
trask:rename/sql-commenter-enabled
Mar 27, 2026
Merged

Rename sql commenter builder option#17094
laurit merged 2 commits intoopen-telemetry:mainfrom
trask:rename/sql-commenter-enabled

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Mar 26, 2026

Related to #17069

@github-actions github-actions Bot added the test native This label can be applied to PRs to trigger them to run native tests label Mar 26, 2026
@trask trask force-pushed the rename/sql-commenter-enabled branch from 7a531a4 to c80d041 Compare March 26, 2026 16:06
Comment on lines +74 to 75
Experimental.setSqlCommenterEnabled(
builder, config.get("sqlcommenter/development").getBoolean("enabled", false));
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already aligns with declarative configuration

@trask trask marked this pull request as ready for review March 27, 2026 00:29
@trask trask requested a review from a team as a code owner March 27, 2026 00:29
@laurit laurit merged commit 986c051 into open-telemetry:main Mar 27, 2026
180 of 183 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test native This label can be applied to PRs to trigger them to run native tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants