Add retry logic to WildFly download in smoke test Dockerfiles#16814
Closed
zeitlinger wants to merge 9 commits into
Closed
Add retry logic to WildFly download in smoke test Dockerfiles#16814zeitlinger wants to merge 9 commits into
zeitlinger wants to merge 9 commits into
Conversation
zeitlinger
marked this pull request as ready for review
March 20, 2026 12:38
jaydeluca
approved these changes
Mar 20, 2026
jaydeluca
self-requested a review
March 20, 2026 16:47
zeitlinger
marked this pull request as draft
March 21, 2026 08:31
zeitlinger
marked this pull request as ready for review
March 21, 2026 09:07
4 tasks
Member
|
@zeitlinger is this related |
Member
Author
|
@trask please check again |
Member
|
I haven't noticed this issue recently (was definitely happening a lot a couple of weeks ago), wonder if they've fixed something and whether this is still worth it |
download.jboss.org intermittently returns 503, causing CI flakes in the Windows WildFly image build job. Signed-off-by: Gregor Zeitlinger <[email protected]>
- Linux: use --retry-on-http-error=503 instead of --retry-connrefused (the latter only handles TCP-level failures, not HTTP 503) - Windows: remove quotes around URL so Docker ARG substitution works with the default cmd shell
Docker expands ${baseDownloadUrl} before passing to cmd /S /C, but
without quotes special characters in the URL can be misinterpreted
by cmd.exe, causing curl exit code 3 (URL malformed).
Transient Docker daemon (connection refused) and HCS (CreateComputeSystem) failures cause frequent Windows CI flakes. Wrap both Gradle steps in a 3-attempt retry loop with 10s backoff, only on windows-latest.
Transient Docker daemon (connection refused) and HCS (CreateComputeSystem) failures cause frequent Windows CI flakes. Wrap both Gradle steps with a retry script (3 attempts on Windows, 1 on Linux) to recover automatically.
Remove duplicated inline retry loops from Build and Test steps in favor of the shared .github/scripts/retry.sh wrapper.
Wrap the Windows docker image builds in pr-smoke-test-servlet-images and publish-smoke-test-servlet-images with retry.sh to handle transient Docker/HCS failures.
Replace ADD (which has no retry support) with PowerShell Invoke-WebRequest wrapped in a retry loop (5 attempts, 3s wait) to handle transient HTTP failures like 503s.
zeitlinger
force-pushed
the
fix-wildfly-download-retry
branch
from
April 8, 2026 12:15
335f1aa to
e5988eb
Compare
Member
Author
maybe no windows builds? But I'll put it back into draft - and we'll see. |
zeitlinger
marked this pull request as draft
April 8, 2026 16:32
Member
|
yeah, was seeing it again today, found another option: #17721 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
download.jboss.orgintermittently returns HTTP 503, causing CI flakes in the WildFly smoke test image build (e.g. #16810 CI failure).--tries=5 --waitretry=3 --retry-connrefusedtowgetADD(no retry support) withcurl.exe --retry 5 --retry-delay 3 --retry-all-errors