Skip to content

chore: update instrumentation list [automated] #16515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trask merged 1 commit into from
Mar 15, 2026
Merged

chore: update instrumentation list [automated] #16515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/instrumentation-list.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12964,6 +12964,7 @@ libraries:
source_path: instrumentation/servlet/servlet-2.2
scope:
name: io.opentelemetry.servlet-2.2
schema_url: https://opentelemetry.io/schemas/1.37.0
Copy link
Copy Markdown
Member

@jaydeluca jaydeluca Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not actually sure which PR caused this update

Copy link
Copy Markdown
Member

@trask trask Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, interesting, from AI, but sounds legit:

The root cause was latent non-determinism from PR #15144 (Nov 2025) adding setSchemaUrl() only to the HTTP server instrumenter but not the response instrumenter, combined with findFirst() over a HashSet in the analysis code. Since EmittedScope.Scope.hashCode() includes schemaUrl and version, the version bump from 2.26.0-alpha-SNAPSHOT to 2.27.0-alpha-SNAPSHOT changed the hash codes of both scope entries, which altered HashSet iteration order and flipped which scope findFirst() returned.

Copy link
Copy Markdown
Member

@jaydeluca jaydeluca Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the determinism of the parsing here: #16546

Should we also add the schemaUrl to the response instrumenter?

Copy link
Copy Markdown
Member

@trask trask Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add the schemaUrl to the response instrumenter?

👍

javaagent_target_versions:
- javax.servlet:servlet-api:[2.2, 3.0)
configurations:
Expand Down Expand Up @@ -13045,6 +13046,7 @@ libraries:
source_path: instrumentation/servlet/servlet-3.0
scope:
name: io.opentelemetry.servlet-3.0
schema_url: https://opentelemetry.io/schemas/1.37.0
has_standalone_library: true
javaagent_target_versions:
- javax.servlet:javax.servlet-api:[3.0,)
Expand Down
Loading