Skip to content

chore: update instrumentation list [automated]#16515

Merged
trask merged 1 commit intomainfrom
otelbot/metadata-update-main
Mar 15, 2026
Merged

chore: update instrumentation list [automated]#16515
trask merged 1 commit intomainfrom
otelbot/metadata-update-main

Conversation

@otelbot-java-instrumentation
Copy link
Copy Markdown
Contributor

This PR was created automatically by the metadata update workflow.

source_path: instrumentation/servlet/servlet-2.2
scope:
name: io.opentelemetry.servlet-2.2
schema_url: https://opentelemetry.io/schemas/1.37.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not actually sure which PR caused this update

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, interesting, from AI, but sounds legit:

The root cause was latent non-determinism from PR #15144 (Nov 2025) adding setSchemaUrl() only to the HTTP server instrumenter but not the response instrumenter, combined with findFirst() over a HashSet in the analysis code. Since EmittedScope.Scope.hashCode() includes schemaUrl and version, the version bump from 2.26.0-alpha-SNAPSHOT to 2.27.0-alpha-SNAPSHOT changed the hash codes of both scope entries, which altered HashSet iteration order and flipped which scope findFirst() returned.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the determinism of the parsing here: #16546

Should we also add the schemaUrl to the response instrumenter?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add the schemaUrl to the response instrumenter?

👍

@otelbot-java-instrumentation otelbot-java-instrumentation Bot force-pushed the otelbot/metadata-update-main branch from e92373d to a561b26 Compare March 15, 2026 02:50
@trask trask merged commit 6a21dfb into main Mar 15, 2026
94 checks passed
@trask trask deleted the otelbot/metadata-update-main branch March 15, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants