Add OTEL_INSTRUMENTATION_COMMON_V3_PREVIEW flag#16459
Merged
laurit merged 2 commits intoopen-telemetry:mainfrom Mar 15, 2026
Merged
Add OTEL_INSTRUMENTATION_COMMON_V3_PREVIEW flag#16459laurit merged 2 commits intoopen-telemetry:mainfrom
laurit merged 2 commits intoopen-telemetry:mainfrom
Conversation
jaydeluca
approved these changes
Mar 12, 2026
| commonConfig.get("logging").getString("span_id", LoggingContextConstants.SPAN_ID); | ||
| loggingTraceFlagsKey = | ||
| commonConfig.get("logging").getString("trace_flags", LoggingContextConstants.TRACE_FLAGS); | ||
| v3Preview = commonConfig.getBoolean("v3_preview", false); |
Member
There was a problem hiding this comment.
so will we auto-enable all the semconv stability opt-ins with this too?
Member
Author
There was a problem hiding this comment.
no, but that's a good idea
laurit
reviewed
Mar 13, 2026
| @@ -124,6 +125,9 @@ public CommonConfig(OpenTelemetry openTelemetry) { | |||
| loggingTraceFlagsKey = | |||
| commonConfig.get("logging").getString("trace_flags", LoggingContextConstants.TRACE_FLAGS); | |||
| v3Preview = commonConfig.getBoolean("v3_preview", false); | |||
Contributor
There was a problem hiding this comment.
I think that I would have omitted common from the property name, but it is fine this way too.
Member
Author
There was a problem hiding this comment.
I don't think we can, because the first level under .java in declarative configuration is limited to objects:
laurit
approved these changes
Mar 13, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to start implementing misc breaking changes by hiding them behind this flag.