Fix class cast exception in servlet instrumentation#16403
Merged
laurit merged 1 commit intoopen-telemetry:mainfrom Mar 9, 2026
Merged
Fix class cast exception in servlet instrumentation#16403laurit merged 1 commit intoopen-telemetry:mainfrom
laurit merged 1 commit intoopen-telemetry:mainfrom
Conversation
robsunday
approved these changes
Mar 6, 2026
| } | ||
| } | ||
|
|
||
| private static String readFully(InputStream is) throws Exception { |
Contributor
There was a problem hiding this comment.
If you would like to simplify a bit the code then this method could be replaced with call to org.apache.commons.io.IOUtils.toString(InputStream)
SylvainJuge
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #16393
Introduced with #15473
Alternative for #16396 (tests are copied from #16396).
In #15473
MappingResolverwas moved out from boot loader, this PR moves it back.