Fix ClassCastException when servlet filter is loaded by a different classloader#16396
Closed
trask wants to merge 3 commits intoopen-telemetry:mainfrom
Closed
Fix ClassCastException when servlet filter is loaded by a different classloader#16396trask wants to merge 3 commits intoopen-telemetry:mainfrom
trask wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
trask
commented
Mar 6, 2026
Comment on lines
+68
to
+72
| @Nullable | ||
| public F get(T object, Class<? extends F> expectedType) { | ||
| F value = get(object); | ||
| return expectedType.isInstance(value) ? value : null; | ||
| } |
Member
Author
There was a problem hiding this comment.
I was thinking it could make sense to use this everywhere just as a safeguard
Contributor
There was a problem hiding this comment.
That would be a lots of changes, could we make the VirtualField implementation store and reuse the Class argument that is passed in the VirtualField.find method call ?
Contributor
|
The issue with this approach is that the functionality will be broken because the returned objet is null. I create #16403 that fixes the issue in a different way. |
Member
Author
|
Closing in favor of #16403 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #16393
cc @SylvainJuge