Skip to content

Fix: rename netty.v4.common package to netty.common.v4_0#16327

Merged
laurit merged 3 commits intomainfrom
copilot/fix-package-name-in-netty
Mar 2, 2026
Merged

Fix: rename netty.v4.common package to netty.common.v4_0#16327
laurit merged 3 commits intomainfrom
copilot/fix-package-name-in-netty

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 28, 2026

The netty-common-4.0 javaagent module used package io.opentelemetry.javaagent.instrumentation.netty.v4.common, which did not match the module name. The correct package places common before the version segment, matching the netty-common-4.0 module name convention.

Changes

  • netty-common-4.0/javaagent — renamed package directory v4/common/common/v4_0/ and updated package declarations in all 5 source files:
    • AbstractNettyChannelPipelineInstrumentation
    • FutureListenerWrappers
    • NettyFutureInstrumentation
    • NettyScope
    • VirtualFieldHelper
  • netty-4.0/javaagent and netty-4.1/javaagent — updated all import statements referencing the old package in BootstrapInstrumentation, NettyChannelPipelineInstrumentation, and NettyInstrumentationModule (6 files total)

Before → After:

// Before
import io.opentelemetry.javaagent.instrumentation.netty.v4.common.NettyScope;

// After
import io.opentelemetry.javaagent.instrumentation.netty.common.v4_0.NettyScope;

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Fix package name from netty.v4.common to netty.v4_0.common Fix: rename netty.v4.common package to netty.v4_0.common Feb 28, 2026
Copilot AI changed the title Fix: rename netty.v4.common package to netty.v4_0.common Fix: rename netty.v4.common package to netty.common.v4_0 Feb 28, 2026
@trask trask marked this pull request as ready for review February 28, 2026 19:36
@trask trask requested a review from a team as a code owner February 28, 2026 19:36
@laurit laurit merged commit 1f03f03 into main Mar 2, 2026
94 checks passed
@laurit laurit deleted the copilot/fix-package-name-in-netty branch March 2, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants