Fix: rename netty.v4.common package to netty.common.v4_0#16327
Merged
Conversation
Co-authored-by: trask <[email protected]>
Copilot
AI
changed the title
[WIP] Fix package name from netty.v4.common to netty.v4_0.common
Fix: rename Feb 28, 2026
netty.v4.common package to netty.v4_0.common
trask
reviewed
Feb 28, 2026
…ty.common.v4_0 Co-authored-by: trask <[email protected]>
Copilot
AI
changed the title
Fix: rename
Fix: rename Feb 28, 2026
netty.v4.common package to netty.v4_0.commonnetty.v4.common package to netty.common.v4_0
trask
approved these changes
Feb 28, 2026
laurit
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
netty-common-4.0javaagent module used packageio.opentelemetry.javaagent.instrumentation.netty.v4.common, which did not match the module name. The correct package placescommonbefore the version segment, matching thenetty-common-4.0module name convention.Changes
netty-common-4.0/javaagent— renamed package directoryv4/common/→common/v4_0/and updatedpackagedeclarations in all 5 source files:AbstractNettyChannelPipelineInstrumentationFutureListenerWrappersNettyFutureInstrumentationNettyScopeVirtualFieldHelpernetty-4.0/javaagentandnetty-4.1/javaagent— updated allimportstatements referencing the old package inBootstrapInstrumentation,NettyChannelPipelineInstrumentation, andNettyInstrumentationModule(6 files total)Before → After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.