Skip to content

Populate os.version resource attribute#16311

Merged
trask merged 3 commits intoopen-telemetry:mainfrom
Arpan200502:fix/os-version-resource-16211
Mar 3, 2026
Merged

Populate os.version resource attribute#16311
trask merged 3 commits intoopen-telemetry:mainfrom
Arpan200502:fix/os-version-resource-16211

Conversation

@Arpan200502
Copy link
Copy Markdown
Contributor

Summary

Fixes #16211

This PR populates the os.version resource attribute in OsResource.

The attribute key was defined but not previously added to the resource attributes.
This change ensures that the operating system version is properly captured and exported as part of resource metadata.

Changes

  • Added OS_VERSION attribute key.
  • Populated os.version using the detected OS version value.

Testing

  • Ran the relevant resource instrumentation tests locally.
  • Verified both tests pass successfully.

@Arpan200502 Arpan200502 requested a review from a team as a code owner February 27, 2026 11:10
Comment thread dads Outdated
@Arpan200502 Arpan200502 force-pushed the fix/os-version-resource-16211 branch from 2320e61 to 249d9d6 Compare February 27, 2026 13:53
@Arpan200502 Arpan200502 requested a review from laurit February 27, 2026 14:21
@Arpan200502 Arpan200502 force-pushed the fix/os-version-resource-16211 branch from 249d9d6 to 4c8c32e Compare February 28, 2026 03:17
Copy link
Copy Markdown
Contributor Author

@Arpan200502 Arpan200502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread dads Outdated
@laurit laurit added this to the v2.26.0 milestone Mar 2, 2026
@Arpan200502
Copy link
Copy Markdown
Contributor Author

why is it not merged , help

@laurit
Copy link
Copy Markdown
Contributor

laurit commented Mar 2, 2026

why is it not merged , help

it will be merged eventually, just wait. You don't need to do anything more.

@trask trask merged commit af832da into open-telemetry:main Mar 3, 2026
93 checks passed
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented Mar 3, 2026

Thank you for your contribution @Arpan200502! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

os.version resource attribute is not populated

3 participants