Merge network/server getter methods into DB attribute getters#16264
Merged
trask merged 3 commits intoopen-telemetry:mainfrom Feb 26, 2026
Merged
Merge network/server getter methods into DB attribute getters#16264trask merged 3 commits intoopen-telemetry:mainfrom
trask merged 3 commits intoopen-telemetry:mainfrom
Conversation
…rt fallback Under stable semconv, when db.namespace/collection/stored_procedure are null, the span name now includes server.address:server.port as the target. Updated jedis-1.4, jedis-3.0, and influxdb-2.4 tests to expect the new span name format conditionally based on emitStableDatabaseSemconv().
trask
commented
Feb 23, 2026
| span -> | ||
| span.hasName("WRITE") | ||
| span.hasName( | ||
| emitStableDatabaseSemconv() ? "WRITE " + host + ":" + port : "WRITE") |
Member
Author
There was a problem hiding this comment.
didn't expect this, but we get better span names!
trask
commented
Feb 23, 2026
Comment on lines
-14
to
-24
| @Nullable | ||
| @Override | ||
| public String getServerAddress(VertxSqlClientRequest request) { | ||
| return request.getHost(); | ||
| } | ||
|
|
||
| @Nullable | ||
| @Override | ||
| public Integer getServerPort(VertxSqlClientRequest request) { | ||
| return request.getPort(); | ||
| } |
Member
Author
There was a problem hiding this comment.
these already existed in VertxSqlClientAttributesGetter
This was referenced Feb 23, 2026
laurit
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following pattern from HTTP instrumentations.