Create new PekkoRouteHolder for each request#16258
Merged
laurit merged 2 commits intoopen-telemetry:mainfrom Feb 26, 2026
Merged
Create new PekkoRouteHolder for each request#16258laurit merged 2 commits intoopen-telemetry:mainfrom
laurit merged 2 commits intoopen-telemetry:mainfrom
Conversation
Previously a request would reuse an existing PekkoRouteHolder if it existed in the Context. This should never happen, since the server should start with a root span, but it seems there's a context leak somewhere allowing multiple requests, and therefore multiple threads, to operate on the same PekkoRouteHolder. This randomly causes issues with concurrent access to StringBuilder and ArrayDeque instances. This might fix issue 15681. It also might not, but it is nevertheless an improvement.
laurit
approved these changes
Feb 26, 2026
Contributor
|
Thank you for your contribution @samwright! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously a request would reuse an existing PekkoRouteHolder if it existed in the Context. This should never happen, since the server should start with a root span, but it seems there's a context leak somewhere allowing multiple requests, and therefore multiple threads, to operate on the same PekkoRouteHolder. This randomly causes issues with concurrent access to StringBuilder and ArrayDeque instances.
This might fix issue #15681. It also might not, but it is nevertheless an improvement.