Support db.system.name in vertx sql instrumentation#16254
Merged
trask merged 5 commits intoopen-telemetry:mainfrom Mar 27, 2026
Merged
Support db.system.name in vertx sql instrumentation#16254trask merged 5 commits intoopen-telemetry:mainfrom
db.system.name in vertx sql instrumentation#16254trask merged 5 commits intoopen-telemetry:mainfrom
Conversation
trask
force-pushed
the
vertx-db-system-name
branch
from
1cac208 to
cf9d33d
Compare
trask
force-pushed
the
vertx-db-system-name
branch
7 times, most recently
from
4ae7367 to
29e1557
Compare
trask
force-pushed
the
vertx-db-system-name
branch
from
5cbd0bc to
e97bcc8
Compare
laurit
reviewed
Mar 26, 2026
laurit
reviewed
Mar 26, 2026
laurit
reviewed
Mar 26, 2026
laurit
reviewed
Mar 26, 2026
| // TODO do better in | ||
| // https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/16254 | ||
| return DOUBLE_QUOTES_ARE_STRING_LITERALS; | ||
| switch (request.getDbSystemName()) { |
Contributor
There was a problem hiding this comment.
should we try to somehow share this with jdbc?
Member
Author
laurit
reviewed
Mar 26, 2026
| @Override | ||
| @Nullable | ||
| public String getDbSystem(VertxSqlClientRequest request) { | ||
| // preserving old behavior: db.system was never set for vertx sql client |
Contributor
There was a problem hiding this comment.
I think it would be fine to stat emitting the db system. I guess the only concern would be that the db system names in old and new semconv are different for some databases.
Member
Author
There was a problem hiding this comment.
yeah, I can add the mapping here if you'd like, otherwise I'm also ok with leaving the old behavior alone
Contributor
There was a problem hiding this comment.
we can leave the old behavior if it is easier
54 tasks
laurit
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.