Add instrumentation for zio http server route#16232
Merged
trask merged 3 commits intoopen-telemetry:mainfrom Feb 20, 2026
Merged
Add instrumentation for zio http server route#16232trask merged 3 commits intoopen-telemetry:mainfrom
trask merged 3 commits intoopen-telemetry:mainfrom
Conversation
breedx-splk
approved these changes
Feb 19, 2026
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Seems like a nice addition for the scala users! Thanks @laurit .
| @Override | ||
| public void transform(TypeTransformer transformer) { | ||
| transformer.applyAdviceToMethod( | ||
| isMethod().and(named("$minus$greater")), getClass().getName() + "$TestAdvice"); |
Contributor
There was a problem hiding this comment.
😎 cool method name $minus$greater .... <>
Contributor
Author
There was a problem hiding this comment.
in scala the method name is ->
| trace.hasSpansSatisfyingExactly(new Consumer[SpanDataAssert] { | ||
| override def accept(span: SpanDataAssert): Unit = { | ||
| span | ||
| .hasName("GET /greet/{name}") |
| t.isInstanceOf(classOf[String]) | ||
| } | ||
| ), | ||
| equalTo(HTTP_ROUTE, "/greet/{name}"), |
| module.set("zio-http_2.12") | ||
| versions.set("[$zioVersion,)") | ||
| // don't care about these versions | ||
| skip("0.0.1", "0.0.2", "0.0.3", "0.0.4", "0.0.5") |
Contributor
There was a problem hiding this comment.
These skip version seem so much lower than the actual zio version 3.0.0....I must be missing something.
Contributor
Author
There was a problem hiding this comment.
Due to assertInverse.set(true) muzzle checks all versions. There are no 1.x or 2.x versions only the 0.x and 3.x. At least one of the 0.x versions has missing dependencies.
jaydeluca
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.