Simplify InfluxDB instrumentation#16207
Merged
trask merged 7 commits intoopen-telemetry:mainfrom Feb 26, 2026
Merged
Conversation
github-actions
Bot
added
the
test native
trask
force-pushed
the
simplify-influxdb
branch
5 times, most recently
from
d592051 to
a144e01
Compare
In stable semconv, when db.namespace is null the span name falls back to including server.address:server.port as the target. Update the test to expect 'WRITE host:port' for stable semconv and 'WRITE' for old semconv.
trask
force-pushed
the
simplify-influxdb
branch
from
a144e01 to
a897b2a
Compare
trask
commented
Feb 20, 2026
Comment on lines
+417
to
+418
| span.hasName("WRITE") | ||
| span.hasName( | ||
| emitStableDatabaseSemconv() ? "WRITE " + host + ":" + port : "WRITE") |
# Conflicts: # instrumentation/influxdb-2.4/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/influxdb/v2_4/InfluxDbRequest.java
laurit
reviewed
Feb 26, 2026
laurit
reviewed
Feb 26, 2026
| "io.opentelemetry.influxdb-2.4", | ||
| DbClientSpanNameExtractor.create(dbAttributesGetter)) | ||
| .addAttributesExtractor(DbClientAttributesExtractor.create(dbAttributesGetter)) | ||
| DbClientSpanNameExtractor.createForMigration(dbAttributesGetter)) |
Contributor
There was a problem hiding this comment.
To me createForMigration looks weird. I wish we could just use DbClientSpanNameExtractor.create.
Member
Author
There was a problem hiding this comment.
To me createForMigration looks weird
yeah, renamed to createWithGenericOldSpanName and improved the javadoc on it
laurit
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to