Skip to content

Remove deprecated peer-service mapping APIs#16165

Merged
laurit merged 5 commits intomainfrom
copilot/remove-deprecated-peer-apis
Feb 17, 2026
Merged

Remove deprecated peer-service mapping APIs#16165
laurit merged 5 commits intomainfrom
copilot/remove-deprecated-peer-apis

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 13, 2026

Removes deprecated PeerServiceResolver, PeerServiceAttributesExtractor, and HttpClientPeerServiceAttributesExtractor classes along with their associated deprecated method overloads and convenience setters.

Deleted classes

  • HttpClientPeerServiceAttributesExtractor → use HttpClientServicePeerAttributesExtractor
  • PeerServiceAttributesExtractor → use ServicePeerAttributesExtractor
  • PeerServiceResolver → use ServicePeerAttributesExtractor

Removed deprecated method overloads

  • HttpClientServicePeerAttributesExtractor.create(HttpClientAttributesGetter, ServicePeerResolver) → use create(HttpClientAttributesGetter, OpenTelemetry)
  • ServicePeerAttributesExtractor.create(ServerAttributesGetter, ServicePeerResolver) → use create(ServerAttributesGetter, OpenTelemetry)

Removed convenience setters

  • DubboTelemetryBuilder.setPeerService(String) → use addAttributesExtractor(AttributesExtractor.constant(...))
  • GrpcTelemetryBuilder.setPeerService(String) → use addAttributesExtractor(AttributesExtractor.constant(...))
  • Experimental.setClientPeerService(ArmeriaClientTelemetryBuilder, String) → use addAttributesExtractor(AttributesExtractor.constant(...))

Internal cleanup

  • Removed bridging constructor and methods from ServicePeerResolver internal class
  • Removed static initializer reference in ArmeriaClientTelemetryBuilder

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Remove deprecated service-peer and peer-service mapping APIs Remove deprecated peer-service mapping APIs Feb 13, 2026
Copilot AI requested a review from trask February 13, 2026 01:28
@trask trask force-pushed the copilot/remove-deprecated-peer-apis branch 2 times, most recently from f7a2210 to 5dc7d74 Compare February 13, 2026 05:32
@trask trask force-pushed the copilot/remove-deprecated-peer-apis branch from 5dc7d74 to 85d7674 Compare February 13, 2026 16:22
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaces PeerServiceResolverTest.java

@trask trask marked this pull request as ready for review February 14, 2026 16:31
@trask trask requested a review from a team as a code owner February 14, 2026 16:31
…ecated-peer-apis

# Conflicts:
#	instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/net/PeerServiceResolverTest.java
@laurit laurit merged commit 5df0621 into main Feb 17, 2026
86 checks passed
@laurit laurit deleted the copilot/remove-deprecated-peer-apis branch February 17, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants