Rename test variables from dbName to namespace for semantic convention alignment#16151
Merged
Rename test variables from dbName to namespace for semantic convention alignment#16151
Conversation
54 tasks
Co-authored-by: trask <[email protected]>
Copilot
AI
changed the title
[WIP] Rename local test variables from dbName to namespace
Rename test variables from dbName to namespace for semantic convention alignment
Feb 12, 2026
trask
force-pushed
the
copilot/rename-dbname-to-namespace
branch
from
23c48d0 to
d0c762e
Compare
trask
reviewed
Feb 12, 2026
| new GenericContainer<>("clickhouse/clickhouse-server:24.4.2").withExposedPorts(8123); | ||
|
|
||
| private static final String dbName = "default"; | ||
| private static final String databaseName = "default"; |
Member
There was a problem hiding this comment.
renaming to databaseName instead of namespace throughout this PR because in these cases it's not the otel db.namespace concept, but really "database name"
trask
approved these changes
Feb 12, 2026
laurit
reviewed
Feb 12, 2026
| private static final String dbName = "jdbcUnitTest"; | ||
| private static final String dbNameLower = dbName.toLowerCase(Locale.ROOT); | ||
| private static final String databaseName = "jdbcUnitTest"; | ||
| private static final String databaseNameLower = databaseName.toLowerCase(Locale.ROOT); |
Contributor
There was a problem hiding this comment.
I guess it is needed because of
wondering whether we should be preserving the case for the database name
laurit
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continued alignment with stable db semconv terminology.