Clear recorded exception when request completes#16138
Merged
trask merged 4 commits intoopen-telemetry:mainfrom Feb 23, 2026
Merged
Clear recorded exception when request completes#16138trask merged 4 commits intoopen-telemetry:mainfrom
trask merged 4 commits intoopen-telemetry:mainfrom
Conversation
pepeshore
reviewed
Feb 12, 2026
| @Nullable | ||
| public static Throwable getException(Context context) { | ||
| AppServerBridge appServerBridge = context.get(AppServerBridge.CONTEXT_KEY); | ||
| public static Throwable getException(Context context, @Nullable Throwable error) { |
Contributor
There was a problem hiding this comment.
It looks like this method can only be called once from now on. This kind of implicit rule is counterintuitive.
You might consider having the method throw an exception—for example, a checked exception like throw new MethodHasBeenCalledException()—or alternatively a RuntimeException, so that callers can become aware of this rule as early as possible.
Contributor
Author
There was a problem hiding this comment.
There generally isn't a reason to call this method more than once. We rely on our tests to verify that this method is called when needed.
trask
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully resolves #16129