Handle sensitive query params in HTTP server instrumentation#16097
Merged
trask merged 8 commits intoopen-telemetry:mainfrom Mar 9, 2026
Merged
Handle sensitive query params in HTTP server instrumentation#16097trask merged 8 commits intoopen-telemetry:mainfrom
trask merged 8 commits intoopen-telemetry:mainfrom
Conversation
laurit
reviewed
Feb 3, 2026
trask
force-pushed
the
sensitive-query-params
branch
4 times, most recently
from
3ee8792 to
64d9758
Compare
trask
force-pushed
the
sensitive-query-params
branch
8 times, most recently
from
a96c83c to
4160a5a
Compare
trask
commented
Feb 5, 2026
Comment on lines
+557
to
+571
| "paramA=valA¶mB=valB, paramA=valA¶mB=valB", | ||
| "AWSAccessKeyId=AKIAIOSFODNN7, AWSAccessKeyId=REDACTED", | ||
| "Signature=39Up9jzHkxhuIhFE9594DJxe7w6cIRCg0V6ICGS0%3A377, Signature=REDACTED", | ||
| "sig=39Up9jzHkxhuIhFE9594DJxe7w6cIRCg0V6ICGS0, sig=REDACTED", | ||
| "X-Goog-Signature=39Up9jzHkxhuIhFE9594DJxe7w6cIRCg0V6ICGS0, X-Goog-Signature=REDACTED", | ||
| "paramA=valA&AWSAccessKeyId=AKIAIOSFODNN7¶mB=valB, paramA=valA&AWSAccessKeyId=REDACTED¶mB=valB", | ||
| "AWSAccessKeyId=AKIAIOSFODNN7¶mA=valA, AWSAccessKeyId=REDACTED¶mA=valA", | ||
| "paramA=valA&AWSAccessKeyId=AKIAIOSFODNN7, paramA=valA&AWSAccessKeyId=REDACTED", | ||
| "AWSAccessKeyId=AKIAIOSFODNN7&AWSAccessKeyId=ZGIAIOSFODNN7, AWSAccessKeyId=REDACTED&AWSAccessKeyId=REDACTED", | ||
| "AWSAccessKeyId=AKIAIOSFODNN7#ref, AWSAccessKeyId=REDACTED#ref", | ||
| "AWSAccessKeyId=AKIAIOSFODNN7&aa&bb, AWSAccessKeyId=REDACTED&aa&bb", | ||
| "aa&bb&AWSAccessKeyId=AKIAIOSFODNN7, aa&bb&AWSAccessKeyId=REDACTED", | ||
| "AWSAccessKeyId=AKIAIOSFODNN7&&, AWSAccessKeyId=REDACTED&&", | ||
| "&&AWSAccessKeyId=AKIAIOSFODNN7, &&AWSAccessKeyId=REDACTED", | ||
| "AWSAccessKeyId=AKIAIOSFODNN7&a&b#fragment, AWSAccessKeyId=REDACTED&a&b#fragment" |
Member
Author
There was a problem hiding this comment.
essentially same test cases from HttpClientAttributesExtractorTest
| * | ||
| * @since 2.0.0 | ||
| */ | ||
| public final class UrlAttributesExtractor<REQUEST, RESPONSE> |
Member
Author
There was a problem hiding this comment.
(note: this class has no usages)
trask
commented
Feb 6, 2026
Comment on lines
+101
to
+102
| List<String> newConfigValue = | ||
| httpConfig.getScalarList("sensitive_query_parameters", String.class); |
Member
Author
There was a problem hiding this comment.
let's block this PR on open-telemetry/semantic-conventions#3403
Contributor
There was a problem hiding this comment.
Maybe it would be better to merge this PR using a temporary name. Could add experimental suffix/prefix or maybe even something like dontuse to indicate that it is subjected to change. This could let us avoid potential conflict resolution.
Member
Author
There was a problem hiding this comment.
Update: I'm trying to get this supported under the .general node by the next SDK release
Member
Author
There was a problem hiding this comment.
Update: this will be available in the upcoming SDK release
trask
force-pushed
the
sensitive-query-params
branch
from
eb8f89e to
2795701
Compare
laurit
reviewed
Feb 11, 2026
laurit
approved these changes
Feb 11, 2026
trask
force-pushed
the
sensitive-query-params
branch
from
573747b to
ddd0d0f
Compare
trask
force-pushed
the
sensitive-query-params
branch
from
ddd0d0f to
2204bae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.