Enable HTTP client query redaction by default in library instrumentation#16096
Merged
trask merged 2 commits intoopen-telemetry:mainfrom Feb 5, 2026
Merged
Conversation
trask
force-pushed
the
enabled-redaction-by-default-in-lib
branch
from
01625e1 to
3c75810
Compare
42 tasks
laurit
reviewed
Feb 3, 2026
| Set<String> knownMethods = HttpConstants.KNOWN_METHODS; | ||
| ToIntFunction<Context> resendCountIncrementer = HttpClientRequestResendCount::getAndIncrement; | ||
| boolean redactQueryParameters; | ||
| boolean redactQueryParameters = true; |
Contributor
There was a problem hiding this comment.
Wondering whether this would be a breaking change if we had stable instrumentations? Or could we get away with it because it only affects an attribute value.
Member
Author
There was a problem hiding this comment.
I believe this change would be acceptable even for stable instrumentation since it only redacts known sensitive parameters (and is essentially a security fix)
laurit
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(it's already enabled by default in the Java agent)