Add SQL summary edge cases tests#16083
Merged
trask merged 4 commits intoopen-telemetry:mainfrom Feb 26, 2026
Merged
Conversation
308662c to
1c9f4c3
Compare
1c9f4c3 to
b06a18c
Compare
54 tasks
f0745f0 to
d9052a6
Compare
d9052a6 to
9a58c1e
Compare
trask
commented
Feb 20, 2026
Comment on lines
+16
to
+20
| /** | ||
| * AI generated edge case tests for SQL query summary generation. Covers database-specific syntax, | ||
| * subqueries, CTEs, window functions, vendor-specific features, and various lexical edge cases. | ||
| */ | ||
| class SqlQuerySummaryEdgeCasesTest { |
Member
Author
There was a problem hiding this comment.
@laurit what do you think about checking this in? I've been using it locally to help find and fix edge cases in the sql summarization. not sure if it's worth baking in to the main test, or leaving as "edge cases" test, or just dropping it
laurit
approved these changes
Feb 26, 2026
…-existent SqlQuerySanitizer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.