Skip to content

Add SQL summary edge cases tests#16083

Merged
trask merged 4 commits intoopen-telemetry:mainfrom
trask:more-sql-summary-tests
Feb 26, 2026
Merged

Add SQL summary edge cases tests#16083
trask merged 4 commits intoopen-telemetry:mainfrom
trask:more-sql-summary-tests

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Feb 1, 2026

No description provided.

@trask trask force-pushed the more-sql-summary-tests branch 3 times, most recently from 308662c to 1c9f4c3 Compare February 14, 2026 17:22
@trask trask changed the title [DRAFT] Add more SQL summary tests Add SQL summary edge cases tests Feb 14, 2026
@trask trask force-pushed the more-sql-summary-tests branch from 1c9f4c3 to b06a18c Compare February 14, 2026 18:04
@trask trask force-pushed the more-sql-summary-tests branch 4 times, most recently from f0745f0 to d9052a6 Compare February 19, 2026 16:44
@trask trask force-pushed the more-sql-summary-tests branch from d9052a6 to 9a58c1e Compare February 20, 2026 18:05
Comment on lines +16 to +20
/**
* AI generated edge case tests for SQL query summary generation. Covers database-specific syntax,
* subqueries, CTEs, window functions, vendor-specific features, and various lexical edge cases.
*/
class SqlQuerySummaryEdgeCasesTest {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurit what do you think about checking this in? I've been using it locally to help find and fix edge cases in the sql summarization. not sure if it's worth baking in to the main test, or leaving as "edge cases" test, or just dropping it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add it.

@trask trask marked this pull request as ready for review February 20, 2026 18:24
@trask trask requested a review from a team as a code owner February 20, 2026 18:24
@trask trask enabled auto-merge (squash) February 26, 2026 15:17
@trask trask disabled auto-merge February 26, 2026 16:13
@trask trask merged commit 45d016a into open-telemetry:main Feb 26, 2026
85 checks passed
@trask trask deleted the more-sql-summary-tests branch February 26, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants