SQL summary: support CTEs (common table expressions)#16079
Merged
trask merged 4 commits intoopen-telemetry:mainfrom Feb 11, 2026
Merged
SQL summary: support CTEs (common table expressions)#16079trask merged 4 commits intoopen-telemetry:mainfrom
trask merged 4 commits intoopen-telemetry:mainfrom
Conversation
54 tasks
trask
force-pushed
the
sql-summary-ctes
branch
4 times, most recently
from
878696c to
da60443
Compare
trask
force-pushed
the
sql-summary-ctes
branch
from
da60443 to
86d791d
Compare
laurit
reviewed
Feb 11, 2026
| void handleIdentifier() { | ||
| if (expectingCteName) { | ||
| // This is the CTE name - record it in global set for filtering CTE references | ||
| cteNames.add(yytext().toLowerCase()); |
Contributor
There was a problem hiding this comment.
Usually we use toLowerCase with Locale.ROOT. Here it shouldn't matter whether the locale is used, though might help to add it for consistency.
laurit
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.