Servlet 5 library instrumentation#16033
Merged
trask merged 2 commits intoopen-telemetry:mainfrom Jan 28, 2026
Merged
Conversation
laurit
commented
Jan 28, 2026
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.instrumentation.servlet.v5_0.internal; |
Contributor
Author
There was a problem hiding this comment.
this and other library instrumentation classes are copied from servlet 3 instrumentation with servlet api types changed from javax to jakarta
laurit
commented
Jan 28, 2026
| import org.junit.jupiter.params.ParameterizedTest; | ||
| import org.junit.jupiter.params.provider.CsvSource; | ||
|
|
||
| public abstract class AbstractTomcatServlet5Test extends AbstractServlet5Test<Tomcat, Context> { |
Contributor
Author
There was a problem hiding this comment.
Changes to tests are also copied from servlet 3. Tests are rearranged to use more @ParameterizedClass which lets us share more code between agent and library instrumentation tests.
jaydeluca
approved these changes
Jan 28, 2026
| ### Add these dependencies to your project | ||
|
|
||
| Replace `OPENTELEMETRY_VERSION` with | ||
| the [latest release](https://central.sonatype.com/artifact/io.opentelemetry.instrumentation/opentelemetry-servlet-5.0). |
Member
There was a problem hiding this comment.
i found it interesting that there were already really old artifacts of this available:
Co-authored-by: Jay DeLuca <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds library instrumentation for servlet 5 similarly to what was done for servlet 3 in #15473