Ratpack library instrumentation: rename three methods#16013
Merged
laurit merged 2 commits intoopen-telemetry:mainfrom Jan 29, 2026
Merged
Ratpack library instrumentation: rename three methods#16013laurit merged 2 commits intoopen-telemetry:mainfrom
laurit merged 2 commits intoopen-telemetry:mainfrom
Conversation
42 tasks
laurit
reviewed
Jan 27, 2026
|
|
||
| /** Returns {@link ExecInterceptor} instance to support Ratpack Registry binding. */ | ||
| public ExecInterceptor getExecInterceptor() { | ||
| public static ExecInterceptor getExecInterceptor() { |
Contributor
There was a problem hiding this comment.
this would be a binary incompatible change, is that ok?
Member
Author
There was a problem hiding this comment.
yeah, it's not ideal to not have deprecation cycle, but we don't make any guarantees about non-stable artifacts
that said, I don't love these method names, I have now renamed them to createExec*, since they're stateless empty objects anyways and so having a single shared instance isn't important
Contributor
There was a problem hiding this comment.
Wondering whether leaving these as non-static would look nicer. It could help if we needed to change them to non-singletons and configure them in some way.
trask
force-pushed
the
ratpack
branch
2 times, most recently
from
9f8bba2 to
a5133a7
Compare
trask
changed the title
laurit
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename